fix a bug where onegraph explorer schema didn't reload on header change #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit e36c6ec |
|
Review app for commit 55e9232 deployed to Heroku: https://hge-ci-pull-1810.herokuapp.com |
rikinsk-zz
approved these changes
Mar 18, 2019
|
Review app https://hge-ci-pull-1810.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onegraph explorer was loading schema only on first load. On header change, onegraph explorer's schema was not reloaded. This PR makes an introspection whenever header values are changed.
Description
As a user, you can use graphiql explorer on different role based schemas
Affected components
Related Issues
Solution and Design
Onegraph explorer performs a diff between new and previous headers by storing the previous headers into the local state.
Steps to test and verify
Try with and without access key
Limitations, known bugs & workarounds