Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for Postgres Arrays #1767

Closed
wants to merge 10 commits into from
Closed

Better support for Postgres Arrays #1767

wants to merge 10 commits into from

Conversation

nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Mar 14, 2019 •
edited
Loading

Description

Allows following types of queries

query q {
  bar: foo (where: { a : { _contained_in : [1,2,3,4,5,6,7,8]  }} ) {
    a
  }

  baz: foo (where: { a : { _contains : [1,2,3,4] }} ) {
    a
  } 
}

And the following mutations with array

mutation m {
  insert_foo ( objects: [ {a: [1,3,5,7,9] } ]){
    affected_rows
    returning {
      a 
      id
    }
  }
}

Affected components

  • Server
  • Tests

Related Issues

#348
#349

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@nizar-m nizar-m requested a review from 0x777 as a code owner March 14, 2019 01:06
@nizar-m nizar-m requested a review from rakeshkky March 14, 2019 01:13
@hasura-bot
Copy link
Contributor

Review app for commit afae0f0 deployed to Heroku: https://hge-ci-pull-1767.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1767-afae0f0

@netlify
Copy link

netlify bot commented Mar 22, 2019

Deploy preview for hasura-docs ready!

Built with commit cb93ebc

https://deploy-preview-1767--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit cb93ebc deployed to Heroku: https://hge-ci-pull-1767.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1767-cb93ebc

@shahidhk shahidhk added the c/server Related to server label Mar 27, 2019
@shahidhk
Copy link
Member

@nizar-m Please add the right merge label.

@nizar-m nizar-m added the s/do-not-merge Do not merge this pull request to master label Apr 3, 2019
@dsandip dsandip added this to the release-candidates milestone Apr 15, 2019
@rikinsk-zz rikinsk-zz mentioned this pull request May 10, 2019
Open
@rakeshkky
Copy link
Member

closing in favour of #2243

@rakeshkky rakeshkky closed this May 21, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1767.herokuapp.com is deleted

hasura-bot pushed a commit that referenced this pull request Aug 2, 2021
@evertedsphere @hasura-bot
pro, server: improve parameterised query hash handling for batched re…
63d5b7a 
…quests (fix #1767)

hasura/graphql-engine-mono#1768

GitOrigin-RevId: 1161540
hasura-bot pushed a commit that referenced this pull request Aug 5, 2021
@evertedsphere @hasura-bot
pro, server: improve parameterised query hash handling for batched re…
090c4c1 
…quests (fix #1767)

hasura/graphql-engine-mono#1768

GitOrigin-RevId: 1161540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x777 0x777 Awaiting requested review from 0x777

@rakeshkky rakeshkky Awaiting requested review from rakeshkky

Assignees
No one assigned
Labels
c/server Related to server s/do-not-merge Do not merge this pull request to master
Projects
None yet
Milestone
release-candidates
Development

Successfully merging this pull request may close these issues.
5 participants
@nizar-m @hasura-bot @shahidhk @rakeshkky @dsandip