Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update literals css (close #1011), update contributing guide #1057

Merged
merged 2 commits into from
Nov 19, 2018

Conversation

rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Nov 19, 2018

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@shahidhk shahidhk changed the title Update literals css update literals css (close #1011), update contributing guide Nov 19, 2018
@shahidhk shahidhk merged commit 2508b32 into hasura:master Nov 19, 2018
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1057.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the update-literals-css branch November 29, 2018 10:33
hasura-bot pushed a commit that referenced this pull request Sep 5, 2024
<!-- The PR description should answer 2 important questions: -->

### What

The plugin URL should be an environment, not a string. This PR fixes
this.

### How

<!-- How is it trying to accomplish it (what are the implementation
steps)? -->

By changing the type

V3_GIT_ORIGIN_REV_ID: e3d4409f2dcbc70f59adc41bf61645977cab6e47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants