Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve documentation on admin secret ☂️ #4055

Open
marionschleifer opened this issue Mar 6, 2020 · 3 comments
Open

docs: improve documentation on admin secret ☂️ #4055

marionschleifer opened this issue Mar 6, 2020 · 3 comments
Assignees
Labels
c/docs Related to docs s/wip Status: This issue is a work in progress

Comments

@marionschleifer
Copy link
Contributor

marionschleifer commented Mar 6, 2020

We need to improve documentation on admin secret.

The following points need to be covered:

@marionschleifer marionschleifer added c/docs Related to docs p/high candidate for being included in the upcoming sprint e/intermediate can be wrapped up in a week labels Mar 6, 2020
@marionschleifer marionschleifer self-assigned this Mar 6, 2020
@tbenst
Copy link

tbenst commented Jul 18, 2020

@marionschleifer did something change from 1.0.0 -> 1.2.2 that affects how to pass admin-secret?

I'm seeing same issue as #4926 from the following commands:

docker run -p 8080:8080 --rm \
       -e HASURA_GRAPHQL_DATABASE_URL=postgres://$POSTGRES_USER:$POSTGRES_PASSWORD@$POSTGRES_SERVER:$POSTGRES_PORT/$DBNAME \
       -e HASURA_GRAPHQL_ADMIN_SECRET=$HASURA_GRAPHQL_ADMIN_SECRET \
       hasura/graphql-engine:v1.2.2 &

hasura-cli console \
    --admin-secret $HASURA_GRAPHQL_ADMIN_SECRET

@scriptonist
Copy link
Contributor

@tbenst Thanks for the feedback, Nothing changed on how the admin secret is passed, but this may be a bug, will look into it.

@tbenst
Copy link

tbenst commented Jul 20, 2020

@scriptonist for me, the issue was I was running these commands on a remote server, and port forwarding only the console port (9695). I'm guessing that browser-side, the console attempts to connect to localhost:8080. When I ran console locally, it worked fine.

To reproduce, ssh to a remote computer, forwarding whatever port you use for hasura-cli run the two commands in #4055 (comment) on remote. On local, go to localhost:9695, and see the invalid admin-secret error.

@marionschleifer marionschleifer added s/wip Status: This issue is a work in progress and removed e/intermediate can be wrapped up in a week p/high candidate for being included in the upcoming sprint labels Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/docs Related to docs s/wip Status: This issue is a work in progress
Projects
None yet
Development

No branches or pull requests

3 participants