Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subscription client provide connection alive callback #77

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

sermojohn
Copy link

This PR enables optionally provided an onConnectionAlive function that will be called when connection alive message is received by the subscription.

This is useful for implementing healthchecks on top of the connection status, as instructed by connection alive messages (actual message differs per protocol).

Copy link

@hgiasac hgiasac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing

@hgiasac hgiasac merged commit aa8b2bc into hasura:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants