Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games-misc/opensfx: fix installation dir #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fat-Zer
Copy link

@Fat-Zer Fat-Zer commented Jan 27, 2019

GAMES_DATADIR variable is not set anywhere, so the data is being
installed to the / instad of /usr/share/games.
Also bump to EAPI 7.

@hasufell hasufell requested a review from hanetzer January 27, 2019 11:09
@hanetzer
Copy link
Collaborator

@Fat-Zer unfamiliar with this, but it looks like its nothing but flat data, right? and GAMES_DATADIR
is /usr/share/games right? If so, looks good, but you should probably go ahead and use EAPI=7
since there are no eclasses you need to dep against, and probably go ahead and revbump it too
(git mv and edit).

@Fat-Zer
Copy link
Author

Fat-Zer commented Jan 30, 2019

I can bump to EAPI=7 , but I'd be glad not to revbump in this case for the sake of not going ahead the main tree versioning, as long as there are no actual improvements.

GAMES_DATADIR variable is not set anywhere, so the data is being
installed to the / instad of /usr/share/games; fix this.
Also bump to EAPI 7.
@hanetzer
Copy link
Collaborator

@Fat-Zer as in, this exists in ::gentoo already?

@Fat-Zer
Copy link
Author

Fat-Zer commented Jan 31, 2019

Yep, for several years already, see. You may still want to keep this around as long as you keep games-simulation/openttd (also in tree), because the package is the game's essential (but still optional) part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants