-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image to ubuntu-base:9.0.4 #491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@renewoensdregt I made progress on the work we shortly discussed in 0f20525#r1453695818 :) |
frenck
requested changes
Mar 20, 2024
9c8ec6f
to
3a413b1
Compare
frenck
requested changes
Mar 21, 2024
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This installs latest mongodb-org-server 4.4 version as the unifi package requires a version << 5.0.0 Beware of the licence change, previous mongodb version was 3.6.9 released under the AGPL, 4.0.3 and newer releases are released under the non-free SSPL https://en.wikipedia.org/wiki/MongoDB#Licensing This commit is in preparation for switching to a more recent base image/ubuntu version, where mongodb is no longer available in the official repositories. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This switches the base image to ubuntu-base:9.0.4, ie ubuntu 22.04. The base deps versions need to be updated. libcap2 is already installed in the base image, so it's removed from the list of packages to install Only the 6.0 and 7.0 repositories contain 'mongodb-org-server' packages for ubuntu 22.04, so we are forced to use one of these versions. However, the unifi package requires a mongodb-org-server version << 5.0.0 so we need to ignore the mongodb-org-server dependency when installing the unifi package. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
frenck
reviewed
Mar 21, 2024
frenck
reviewed
Mar 21, 2024
While there are no mongodb-org-server 4.4 builds available in mongodb's ubuntu 22.04 repos, there are such builds in the 20.04 repos. We need to manually install the older libssl version mongodb-server requires. This reuses what is done in glennr unifi install scripts. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
frenck
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cfergeau 👍
../Frenck
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This switches from ubuntu-base:8 to ubuntu-base:9 as the base image (ie ubuntu 20.04 to ubuntu 22.04).
The main complication is mongodb, it's now installed from mongodb community servers as it's gone from newer ubuntu repositories. Beware of the licence change, previously the addon used mongodb version 3.6.9 released under the AGPL, while 4.0.3 and newer are released under the non-free SSPL
https://en.wikipedia.org/wiki/MongoDB#Licensing
Installing mongodb 4.4 which is compatible with the unifi package requires some hackish install of the appropriate libssl.
mongodb 7.0 is easier to install, but requires the use of
--ignore-depends=mongodb-org-server
when installing the unifi package.I couldn't make my mind regarding which option is best, so it's easy to pick one or the other by keeping/removing the last commit in this PR.