Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📚 Update installation doc with proper link #323

Merged
merged 2 commits into from
Jul 28, 2022
Merged

📚 Update installation doc with proper link #323

merged 2 commits into from
Jul 28, 2022

Conversation

delphiki
Copy link
Contributor

Proposed Changes

Fix the link to set the IPv4 to static

Related Issues

N/A

@frenck frenck added the documentation Solely about the documentation of the project. label Jun 24, 2022
@frenck frenck changed the title fix(doc): update installation doc with proper link 📚 Update installation doc with proper link Jun 24, 2022
@frenck
Copy link
Member

frenck commented Jun 24, 2022

CI fails on line length, could you take a look?

@delphiki
Copy link
Contributor Author

It should be fixed :)

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jul 25, 2022
@delphiki
Copy link
Contributor Author

Hey @frenck, do I still need to fix something?

@frenck
Copy link
Member

frenck commented Jul 25, 2022

yes, as I said before, the CI is failing. This hasn't been resolved.

CleanShot 2022-07-25 at 15 15 04

@delphiki
Copy link
Contributor Author

yes, as I said before, the CI is failing. This hasn't been resolved.

CleanShot 2022-07-25 at 15 15 04

I saw that, but I thought this was more of a CI problem, judging by the error: https://github.com/hassio-addons/addon-adguard-home/runs/7045382389?check_suite_focus=true

@frenck
Copy link
Member

frenck commented Jul 25, 2022

It isn't a CI issue. The files are not formatted with Prettier.
The CI tries to fix that but hasn't got permission to do so.

The solution is to format changed files using prettier.

@delphiki
Copy link
Contributor Author

Okay I see, thanks for the explanation, I'll fix that asap :)

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jul 26, 2022
frenck
frenck reviewed Jul 28, 2022
View reviewed changes
frenck
frenck approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @delphiki 👍

@frenck frenck merged commit 9fbb330 into hassio-addons:main Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
documentation Solely about the documentation of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delphiki @frenck