Repository navigation
fix(di): 🐛 Keep legacy base64 service ids with node-dependency-injection 4 - #84
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-dependency-injection 4 generates human-readable service ids by default, but the kernel's class-based resolution (parent aliases, overrides, service lookup) decodes base64 ids. In
containerBuildmode this left overrides unmatched, so override classes were registered without their constructor arguments (e.g.Cannot read properties of undefinedin consumers) and abstract-parent aliasing broke.Switch the autowire to the legacy base64 id strategy so generated
services.yamlfiles keep the format the kernel expects. Adds a regression test that checks the generated ids.