Always sys/random.h, I don't like Apple nor Google equally now #98
+58
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
force-pushed
the
sys-random-always
branch
2 times, most recently
from
184de04 to
4072bc6
Compare
... because apparently some systems don't expose getentropy via unistd.h (as POSIX suggests since recently). (Some systems include Android). While we are on it: - Use `RtlGenRandom` on Windows instead of time - Use `SecRandomCopyBytes` on macos and ios I have no access to ios devices, but if SecRandomCopyBytes approach works on macos, I hope it works on ios. `getentropy` is reported to not work on `ios` elsewhere.
phadej
force-pushed
the
sys-random-always
branch
from
4072bc6 to
cdddad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97