Add oauth1 support #45
Conversation
|
@bos Hey, sorry to bother you, but can you take a look at this to see if it's mergeable? |
|
@bos Hi, i would find these quite useful for project i'm working on right now, would you mind take a look please? |
|
Hmm, I could actually make use of this... could someone make a fork with this... and put it on hackage. |
|
Bumping this. Was looking to add in OAuth1 support myself, but it looks like @jsantos17 has done it. Does any additional work need to be done on integration or is this pretty much ready to roll? Would appreciate a look if you get a chance, @bos. Thanks! |
| @@ -177,6 +177,7 @@ data Auth = BasicAuth S.ByteString S.ByteString | |||
| | AWSAuth AWSAuthVersion S.ByteString S.ByteString | |||
| -- ^ Amazon Web Services request signing | |||
| -- AWSAuthVersion key secret | |||
| | OAuth1 S.ByteString S.ByteString S.ByteString S.ByteString | |||
|
Sorry for the slow response; I was on vacation. You'll see that I have a few comments, but otherwise this looks good. |
| @@ -117,8 +118,10 @@ prepare modify opts url = do | |||
| signRequest = maybe return f $ auth opts | |||
| where | |||
| f (AWSAuth versn key secret) = AWS.signRequest versn key secret | |||
There was a problem hiding this comment.
[bos wrote] While you're at it, please also fix that API mistake for the AWS code in a separate commit
We're not passing the auth record to AWS.signRequest, but only the constituent parts. What could I do better here?
|
@bos thanks for the review. I'll get the changes done ASAP :) |
|
@bos any chance of getting this merged? |
|
👍 |
1 similar comment
|
👍 |
|
Applied, thanks! |
This adds support for OAuth1. Has only been tested with Twitter's API. I can add tests if there's interest in getting this merged.