Skip to content

Fix ci: ensure we have a supported ghc version in PATH #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 9, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Nov 6, 2021

  • A recent github workflows vm update set ghc to 9.2.1 in Linux, and hls does not support it
  • This pr uses haskell/actions/setup to explicitly set a supported ghc version (9.0.1)
  • In the way i added some improvements to help to debug the issue:
    • The client log output is written in the log file is the config option is specified
    • Client log output has a more verbose level: debug
    • Tests use the log file contents to make checks, it is included in the workflow step and uploaded as artifact if the test suite fails

/cc @jacobprudhomme, as i have modified some of the code recently added in your pr

@jneira jneira force-pushed the fixci branch 3 times, most recently from 12392f9 to 8aad31f Compare November 6, 2021 21:26
@jneira jneira changed the title Use ubuntu-18.04 to try to fix ci Fix ci: ensure we have a supported ghc version in PATH Nov 8, 2021
@jneira jneira requested a review from berberman November 8, 2021 21:43
@jneira jneira merged commit 627b1da into haskell:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant