Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for overwriting of .ddump-timing in tests #507

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

Shimuuar
Copy link
Contributor

Enable CPP per module in tests

This is workaround for problem of benchmarking build time.
When package is compiled with GHC flags `-ddump-timings -ddump-to-file`
*.dump-timings files corresponding to modules with enabled CPP gets overwritten
at link time.

Timing for Utilities still get lost but its contribution is small anyway
and we're able to keep timings for other modules

Note that libraries are not affected by this problem.

Also unbreak CI which stopped working after upgrading ubuntu-latest to 24.04

This is workaround for problem of benchmarking build time.
When package is compiled with GHC flags `-ddump-timings -ddump-to-file`
*.dump-timings files corresponding to modules with enabled CPP gets overwritten
at link time.

Timing for Utilities still get lost but its contribution is small anyway
and we're able to keep timings for other modules

Note that libraries are not affected by this problem.
github actions upgraded to Ubuntu 24.04 and all uses of PAPI and GHC 8.0, 8.2
immediately broke. Easiest way is to roll back to 22.04
@Shimuuar Shimuuar merged commit 3322046 into master Oct 14, 2024
22 checks passed
@Shimuuar Shimuuar deleted the ddump-timing-CPP branch October 14, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant