Skip to content

add post jobs to github workflows #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

kokobd
Copy link
Collaborator

@kokobd kokobd commented Aug 23, 2022

Mergify relies on branch protection settings, which can only be configured here:
image

When a PR changes the test matrix, Mergify will still wait for the old jobs that no longer exist. See #446 for an example.

HLS repo uses post jobs for each workflow and sets branch protection rules to wait for those post jobs.

@kokobd kokobd marked this pull request as ready for review August 23, 2022 06:51
@kokobd
Copy link
Collaborator Author

kokobd commented Aug 23, 2022

@michaelpj Do you have access to the repository settings page? If so, can you set the branch protection rule of the master branch to check haskell_post_job and nix_post_job instead?

@kokobd kokobd requested a review from michaelpj August 23, 2022 07:06
@michaelpj michaelpj merged commit 85c30b4 into haskell:master Aug 23, 2022
@michaelpj
Copy link
Collaborator

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants