Skip to content

Remove dynamic indentation showing #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2015
Merged

Remove dynamic indentation showing #947

merged 1 commit into from
Oct 22, 2015

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Oct 18, 2015

haskell-indentation had the option to put overlay underlines at positions eligible as indentation points. This was supposed to help usability and debugging of indentation algorithm. It practice is was slow, distracting and a test suite helps development much better.

haskell-indentation had the option to put overlay underscores at
positions eligible as indentation points. This was supposed to help
usability and debugging of indentation algorithm. It practice is was
slow, distracting and a test suite helps development much better.
@PierreR
Copy link
Contributor

PierreR commented Oct 18, 2015

Is it what hi2 provided at the time before it was integrated within indentation ?

If so I personally don't mind the removal but many users might actually like it ... Why not just disable the option by default ?

@gracjan
Copy link
Contributor Author

gracjan commented Oct 18, 2015

Reasons to remove haskell-indentation-show-indentations:

  • haskell-indentation-show-indentations is 170 lines less to support and maintain
  • some potential contributors feel intimidated by the size of haskell-indentation, this might get us below their scare limit and contribute
  • the first question after integrating hi2 was integrated 'how to disable haskell-indentation-show-indentations?'
  • second question was 'haskell-indentation-show-indentations interacts badly with my other modes, can you fix it?'
  • haskell-indentation-show-indentations was super slow, now has caching and throttling, but it is still slow
  • haskell-indentation-show-indentations is disabled by default meaning that nobody will find the switch to turn it on
  • haskell-indentation-show-indentations has most probably has zero users on this planet
  • we have zero unit tests for haskell-indentation-show-indentations
  • we have zero documentation for haskell-indentation-show-indentations

@PierreR
Copy link
Contributor

PierreR commented Oct 18, 2015

Somehow all these questions should have come up when hi2 was integrated. I was not aware the integration had been a complete failure.

Don't want to blame anybody. I know there is a shortage of human resource and I understand the decision. Thanks for the quick response (I haven't forgot I need to contribute myself and write some docs about spacemacs ;-)

@gracjan
Copy link
Contributor Author

gracjan commented Oct 18, 2015

@PierreR: My response was about haskell-indentation-show-indentations only as it was a nice attempt and we have learned more in practice. Therefore I do not understand your comment in your first paragraph.

I do understand and endorse your second paragraph, though :)

gracjan added a commit that referenced this pull request Oct 22, 2015
@gracjan gracjan merged commit ee55de1 into haskell:master Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants