Skip to content

Add support for type/data family declarations. #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

yuriy0
Copy link
Contributor

@yuriy0 yuriy0 commented Jul 6, 2015

While type families are not part of the either the Haskell 98 or 2010 standards, they have become nearly ubiquitous. It would be nice for the syntax highlighter to support type/data family declarations. It, perhaps coincidentally, supports type/family instance declarations, but the word `family' is not highlighted in either

type family X 
data family Y

This patch highlights the above correctly.

@gracjan
Copy link
Contributor

gracjan commented Jul 6, 2015

Thanks.

Have you checked if haskell-indentation works? It usually requires a couple of changes after learning a new keyword it needs to know how to handle it.

@gracjan
Copy link
Contributor

gracjan commented Jul 6, 2015

Please remove the change in haskell-indentation. It does not help but may break things.

Does not help here:

data family X
= X

breaks things here:

func x = do
  family <- x

@gracjan
Copy link
Contributor

gracjan commented Jul 23, 2015

@yuriy0: Can you update this one? It would be really good to merge (but haskell-indentation part must be removed).

@gracjan
Copy link
Contributor

gracjan commented Sep 28, 2015

@yuriy0: Can you update this one as described?

@gracjan
Copy link
Contributor

gracjan commented Oct 8, 2015

@yuriy0: ping!

@gracjan
Copy link
Contributor

gracjan commented Nov 20, 2015

@yuriy0, ping.

Is there anybody that would like to take over these changes?

@bergey
Copy link
Contributor

bergey commented Nov 21, 2015

I can adopt this one, but I can't get to it real soon. Ping me if I haven't finished in 3 weeks? Of course, if someone else gets to it sooner, that's great.

@gracjan
Copy link
Contributor

gracjan commented Jan 6, 2016

@bergey: Can you take care of this one? Would be great!

@bergey
Copy link
Contributor

bergey commented Jan 6, 2016

Thanks for the reminder. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants