Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added haskell-hayoo-url as a custom variable #516

Merged
merged 1 commit into from
Mar 16, 2015
Merged

Added haskell-hayoo-url as a custom variable #516

merged 1 commit into from
Mar 16, 2015

Conversation

tonyday567
Copy link
Contributor

It looked like the hard-coded url was being redirected to a new url, and went with the new one as the default. Added url-hexify-string to query.

@gracjan
Copy link
Contributor

gracjan commented Mar 15, 2015

I'm a bit lost, does this pull request work together with #511 or instead of #511?

@tonyday567
Copy link
Contributor Author

@gracjan, it's completely independent to #511. I just saw that the hayoo url was hardcoded and thought I may as well generalise it the same way as the hoogle edit.

@gracjan
Copy link
Contributor

gracjan commented Mar 16, 2015

I see. Someday we need to generalize hayoo and hoogle handling as the code looks very similar for both.

gracjan added a commit that referenced this pull request Mar 16, 2015
Added haskell-hayoo-url as a custom variable
@gracjan gracjan merged commit 139b2db into haskell:master Mar 16, 2015
@tonyday567 tonyday567 deleted the hayoo-url branch March 17, 2015 01:22
@tonyday567
Copy link
Contributor Author

@gracjan,, yes, or rationalise the hayoo and hoogle libraries even ;)

@gracjan
Copy link
Contributor

gracjan commented Mar 17, 2015

and by 'rationalize' you mean...?

@tonyday567
Copy link
Contributor Author

I meant that they do the same thing, and thus it would be beneficial to users of both libraries to work towards a common API, and perhaps look at commonalities in code. Just my idle opinion.

@gracjan
Copy link
Contributor

gracjan commented Mar 17, 2015

Do you see obvious commonalities in code? You have changed that part of the code recently, is there something obvious that you could also improve before you forget?

@tonyday567
Copy link
Contributor Author

No, nothing comes to mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants