Skip to content

Keep point in haskell-simple-indent. #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2015
Merged

Keep point in haskell-simple-indent. #430

merged 3 commits into from
Jan 21, 2015

Conversation

gracjan
Copy link
Contributor

@gracjan gracjan commented Jan 17, 2015

Keep point in sane positions after haskell-simple-indent. This commit
solves multiple problems:

  • messing line content when indent offset was not found
  • getting to the biggining of line in couple of cases
  • failing to indent second line in the buffer in some cases

Make indentation more predictable to users.

Keep point in sane positions after haskell-simple-indent. This commit
solves multiple problems:

- messing line content when indent offset was not found
- getting to the biggining of line in couple of cases
- failing to indent second line in the buffer in some cases

Make indentation more predictable to users.
Fix point handling in haskell-simple-indent-backtab so that it is no as
surprising as it used to be. This commit:

- if point is before indentation, move it to indentation
- keep point at the same character before and after
Introduce backward compatibility shim for lack of indent-next-tab-stop
function.
@gracjan
Copy link
Contributor Author

gracjan commented Jan 19, 2015

@purcell, build is fixed.

Question: is there an official minimal version of Emacs that should be supported?

@purcell
Copy link
Member

purcell commented Jan 19, 2015

Question: is there an official minimal version of Emacs that should be supported?

README says 23 and up, but we have no Travis build for Emacs < 24, and I think we're all being careful to maintain 23.x compatibility these days. @chrisdone - please correct me if I'm wrong. Perhaps we should start assuming >= 24.1.

@gracjan
Copy link
Contributor Author

gracjan commented Jan 19, 2015

Well, my recent patches did not have Emacs 23 in mind.

Without a working Travis build for Emacs 23 it will be hard to keep supporting it in clean conscious.

@gracjan
Copy link
Contributor Author

gracjan commented Jan 21, 2015

@purcell? This commit really improves usability!

purcell added a commit that referenced this pull request Jan 21, 2015
@purcell purcell merged commit fa09425 into haskell:master Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants