Stop blocking me from typing my code

[mrkkrp]

Sometimes I get blocked and I cannot enter newlines. Message in minibuffer says:

Illegal token: import

I believe it's haskell-indentation-mode. My opinion is that it should never block user from typing.

Not sure to reproduce this reliably, but I'll find out when I have time.

[geraldus]

Same here with

Illegal token: where

[Shimuuar]

Also see #861 and #962

[mgsloan]

Yeah, it's pretty shocking to me that something like "intelligent" indent would have the possibility of throwing an exception and refusing to do anything. This should just be a guess, requiring valid code before the point is absurd.

Instead of rewriting the whole thing to not use exceptions, how about catching them? Then, log them and fall back on a very simple indent scheme like just using the current line's indent.

[mrkkrp]

@mgsloan, In my case I'm pretty sure code before point was valid Haskell.

[mgsloan]

Yeah, I guess my point is that "code before the point is valid Haskell" is not a reasonable requirement for automatic indentation.

[gracjan]

haskell-indentation-mode should work for any unicode character string, trying to make sense out of it as much as it can.

It should never throw any kind of exceptions.

The proposed solutions seem to be to catch exceptions and cover up then. I think it should never throw in the first place. Note that there are only three places where haskell-indentation-mode throws:

• haskell-mode/haskell-indentation.el

  Line 461 in 709903a

  (haskell-indentation-parse-error

• haskell-mode/haskell-indentation.el

  Line 769 in 709903a

  (end (haskell-indentation-parse-error

• haskell-mode/haskell-indentation.el

  Line 1036 in 709903a

  (t (haskell-indentation-parse-error "Expecting %s" (cadr phrase))))))

It should not be too hard to invent something sensible for each of these places to do instead of throwing exception.

Any takers?