Repository navigation
Conversation
Contributor
Could you use |
alexfmpe
reviewed
Sep 17, 2026
|
|
||
| -- TODO: here we convert a set into a list and then do n lookup (in | ||
| -- log(k), hence nlog(k).). However we may be able to do something smarter with | ||
| -- "restrictKeys" which runs in nlog(n/k + 1). |
Contributor
There was a problem hiding this comment.
Welp, this nerd sniped me big time.
I thought "why not simply convert both the map and set to lists and then work through the heads of both lists similarly to the merge part of mergesort" and fell down quite a rabbit hole: haskell/containers#1256
Collaborator
Author
There was a problem hiding this comment.
Haha, sorry ;) Super interesting discussion and research ! Thank you.
guibou
force-pushed
the
ghc_9142rc1
branch
5 times, most recently
from
September 21, 2026 11:20
cbb220c to
8547ae9
Compare
This is a work in progress in order to get something which runs with 9.14.2 (rc2). For now, the correct CPP guard are not implemented (because I don't know how to be robust here) and also because the API can still change. See ghc commit 9105d7a3
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress in order to get something which runs with 9.14.2. For now, the correct CPP guard are not implemented (because I don't know how to be robust here) and also because the API can still change.