Skip to content

Add GitHub Actions CI for testing #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 19, 2020
Merged

Add GitHub Actions CI for testing #504

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a13dcdf
Add GitHub workflow for testing
lukel97 Aug 12, 2020
3b323fa
Add HLS_TEST_EXE env var to control which exe to test
lukel97 Oct 14, 2020
c17c379
Pass -j1 flag to tasty when running tests on GitHub
lukel97 Oct 14, 2020
9a008ef
Enable stack in GitHub CI
lukel97 Oct 14, 2020
7dd31a4
Update cabal
lukel97 Oct 14, 2020
6e35e07
Add HLS_WRAPPER_TEST_EXE
lukel97 Oct 16, 2020
d83e651
Fix cache restore keys
lukel97 Oct 16, 2020
5369244
Try force language server to use utf8 locale
lukel97 Oct 17, 2020
85ab899
Use patched hie-bios
lukel97 Oct 17, 2020
8f8e9e1
Remove debug print
lukel97 Oct 17, 2020
0c5cc85
Lets find out what the windows locale encoding is
lukel97 Oct 18, 2020
f917430
Give up trying to fix the locale
lukel97 Oct 18, 2020
9328aa6
Add comment for -j1
lukel97 Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass -j1 flag to tasty when running tests on GitHub
  • Loading branch information
@lukel97
lukel97 committed Oct 15, 2020
commit c17c37968e7dee29ba05d7e997b64ef4eb1ea0d6
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,5 @@ jobs:
- name: Test
env:
HLS_TEST_EXE: hls
run: cabal test
run: cabal test --test-options=-j1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you add -j1 due a concrete issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of precaution, the tests previously failed on circleci because without -j1 tasty attempts to run all the functional tests in parallel, which means it spins up 20 or so hls instances simultaneously. I'm not sure if the GitHub runners can handle it or not but the circleCI runners definitely couldn't!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it worths a comment?