Fix Signature Help inside do Notation #4904
Open
vidit-od wants to merge 1 commit intohaskell:masterfrom
Open
Conversation
Some nodes have there type info stored in nodes generated by ghc. In case no type info found in source node, fall back to traversing ghc generated nodes for types Signed-off-by: vidit-od <vidit894@gmail.com>
vidit-od
changed the title
do Notation
jian-lin
requested changes
Apr 19, 2026
Collaborator
jian-lin
left a comment
jian-lin
left a comment
There was a problem hiding this comment.
Looks good. I'll do a more careful review later.
In the meantime, it would be good to add a test case for the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes : #4769
As recommended, Type information of Some nodes were stored in GHC generated nodes.
This PR keeps the old pipeline and add a Fall back to traverse these generated nodes in case source node lack type information.
Attached image of signature help in cases where we did not get them before;
Prerequisite :
Major Finding credits : @jian-lin