Skip to content

Simplify FuzzySearch test (avoid dependency on /usr/share/dict/words) #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 31, 2025
Merged

Simplify FuzzySearch test (avoid dependency on /usr/share/dict/words) #4531

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9dbbed
Ensure /usr/share/dict/words is installed in CI
jhrcek Mar 27, 2025
e669764
Not in release, but in test job
jhrcek Mar 27, 2025
079eebc
Add sudo
jhrcek Mar 27, 2025
e9fda53
Do it in setup-build action instead of pre_job
jhrcek Mar 27, 2025
ebee93c
Use quickcheck === to get more informative errors
jhrcek Mar 27, 2025
cb52c79
Replace fuzzy search test with few simpler unit tests
jhrcek Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use quickcheck === to get more informative errors
  • Loading branch information
@jhrcek
jhrcek committed Mar 31, 2025
commit ebee93c0abdc427d76b0c5c8c08ef2f5d2961796
6 changes: 3 additions & 3 deletions ghcide-test/exe/FuzzySearch.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ tests =
]
]

test :: Text -> Bool
test :: Text -> Property
test candidate = do
let previous =
catMaybes
Expand All @@ -38,7 +38,7 @@ test candidate = do
| d <- dictionary
]
new = catMaybes [(d,) <$> match candidate d | d <- dictionary]
previous == new
previous === new

propLegit :: Property
propLegit = forAll (elements dictionary) test
Expand Down Expand Up @@ -91,7 +91,7 @@ referenceImplementation :: forall s t.
referenceImplementation pat' t pre post extract =
if null pat then Just (Fuzzy t result totalScore) else Nothing
where
null :: (T.TextualMonoid s) => s -> Bool
null :: s -> Bool
null = not . T.any (const True)

s = extract t
Expand Down