Cabal plugin: implement check for package.yaml in a stack project #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "added guardAgainstHpack function" This reverts commit f7fb00c. added guardAgainstHpack function
fendor
changed the title
fendor
requested changes
Oct 12, 2024
VeryMilkyJoe
requested changes
Oct 12, 2024
Co-authored-by: VeryMilkyJoe <jana.chadt@nets.at>
fendor
approved these changes
Oct 12, 2024
VeryMilkyJoe
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #4400
Modifies
findResponsibleCabalFilefunction to addguardAgainstHpackfunction which checks if apackage.yamlfile exists in the same directory as the.cabalfile and handles the response in the cabal plugin.Prevents stack from not more re-generating .cabal file if package.yaml is changed.