Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove componentInternalUnits #4350

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Jul 7, 2024

componentInternalUnits is always [], we can safely remove it.

@soulomoon soulomoon marked this pull request as ready for review July 7, 2024 10:54
@soulomoon soulomoon requested review from wz1000 and fendor as code owners July 7, 2024 10:54
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@soulomoon soulomoon merged commit 3862e7a into master Jul 8, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants