Skip to content

Formalize the ProgressReporting Type #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 30, 2024
Merged

Formalize the ProgressReporting Type #4335

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
20b4304
add ProgressReportingNoTrace
soulomoon Jun 28, 2024
faceb54
fix doc
soulomoon Jun 28, 2024
5527b11
cleanup
soulomoon Jun 28, 2024
acaa7ba
stylish
soulomoon Jun 28, 2024
f17af2b
turn ProgressReporting into IO
soulomoon Jun 28, 2024
03961fa
rename
soulomoon Jun 28, 2024
99e37f2
Revert "rename"
soulomoon Jun 28, 2024
201946e
rename
soulomoon Jun 28, 2024
a3397ef
rename to PerFileProgressReporting
soulomoon Jun 28, 2024
448675b
prefix hidden field with `_`
soulomoon Jun 28, 2024
202d862
Merge branch 'master' into soulomoon/formlization-of-ProgressReporting
soulomoon Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@soulomoon
soulomoon committed Jun 28, 2024
commit 5527b119d7e8a7811d756867a9bda34bbdfc4d79
3 changes: 1 addition & 2 deletions ghcide/src/Development/IDE/Core/ProgressReporting.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,7 @@ progressReporting (Just lspEnv) title optProgressStyle = do
inProgressState <- newInProgress
progressReportingInner <- progressReportingNoTrace (readTVar $ todoVar inProgressState)
(readTVar $ doneVar inProgressState) (Just lspEnv) title optProgressStyle
let
inProgress :: forall a. NormalizedFilePath -> m a -> m a
let inProgress :: forall a. NormalizedFilePath -> m a -> m a
inProgress = updateStateForFile inProgressState
return ProgressReporting {..}
where
Expand Down