Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -fno-show-error-context from GHC 9.8 #4295

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Use -fno-show-error-context from GHC 9.8 #4295

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ac748c4
Use -fno-show-error-context from GHC 9.8
dsaenztagarro Jun 8, 2024
1a0c106
Search infix hole directly in file text
dsaenztagarro Jun 9, 2024
71a6e9c
Fixes code action add instance constraint
dsaenztagarro Jun 9, 2024
57dccc2
Extracted textInRange function to Util module
dsaenztagarro Jun 10, 2024
fa8b718
CodeAction: fixed add default type to satisfy one constraint
dsaenztagarro Jun 26, 2024
177d306
Merge branch 'master' into use-flag-no-show-error-context
dsaenztagarro Jun 26, 2024
36b98ce
Fixes bad merge
dsaenztagarro Jun 27, 2024
8ce8043
Fixes type annotations satisfying multiple constraints
dsaenztagarro Jun 30, 2024
7ddac39
Merge branch 'master' into use-flag-no-show-error-context
dsaenztagarro Jun 30, 2024
fff2c5e
Use #elif compilation directive
dsaenztagarro Jun 30, 2024
56acfe6
HlsClassPlugin: fixes parsing diagnostic
dsaenztagarro Jul 6, 2024
b6ffd3c
HlsRefactorPlugin: fixes stylish haskell
dsaenztagarro Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes type annotations satisfying multiple constraints
  • Loading branch information
@dsaenztagarro
dsaenztagarro committed Jun 30, 2024
commit 8ce8043410a2a9caeb882f68cc2646940ecb66a8
3 changes: 2 additions & 1 deletion plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,11 +835,12 @@ suggestAddTypeAnnotationToSatisfyConstraints sourceOpt Diagnostic{_range=_range,
where
makeAnnotatedLit ty lit = "(" <> lit <> " :: " <> ty <> ")"
#if MIN_VERSION_ghc(9,8,0)
pat multiple _ _ _ = T.concat [ ".*Defaulting the type variable "
pat multiple at _ _ = T.concat [ ".*Defaulting the type variable "
, ".*to type ‘([^ ]+)’ "
, "in the following constraint"
, if multiple then "s" else " "
, ".*arising from the literal ‘(.+)’"
, if at then ".+at ([^ ]*)" else ""
]
#else
#if MIN_VERSION_ghc(9,4,0)
Expand Down