Skip to content

Replace checkHomeUnitsClosed with a faster implementation #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Replace checkHomeUnitsClosed with a faster implementation #4109

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1610a6d
Use a faster implementation of checkHomeUnitsClosed
wz1000 Mar 1, 2024
341f42f
Update ghcide/src/Development/IDE/GHC/Compat/Core.hs
wz1000 Apr 23, 2024
7df36d0
Update ghcide/session-loader/Development/IDE/Session.hs
wz1000 Apr 23, 2024
eef08bc
Follow guidelines
wz1000 Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ghcide/session-loader/Development/IDE/Session.hs 
Co-authored-by: Jan Hrcek <2716069+jhrcek@users.noreply.github.com>
  • Loading branch information
@wz1000 @jhrcek
wz1000 and jhrcek authored Apr 23, 2024
commit 7df36d080ff25c4077ad452c4ac52e0a8456606f
2 changes: 1 addition & 1 deletion ghcide/session-loader/Development/IDE/Session.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ setNameCache :: IORef NameCache -> HscEnv -> HscEnv
setNameCache nc hsc = hsc { hsc_NC = nc }

#if MIN_VERSION_ghc(9,3,0)
-- This function checks then important property that if both p and q are home units
-- This function checks the important property that if both p and q are home units
-- then any dependency of p, which transitively depends on q is also a home unit.
-- GHC had an implementation of this function, but it was horribly inefficient
-- We should move back to the GHC implementation on compilers where
Expand Down