Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GHC2021 #4033

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Use GHC2021 #4033

merged 3 commits into from
Feb 2, 2024

Conversation

michaelpj
Copy link
Collaborator

I think this looks fairly good, cuts down our extension spam a bit.

@soulomoon
Copy link
Collaborator

I like this idea.

Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea especially in a codebase that's more like an application than like a library.
FYI I resolved merge conflict caused by my PR and pushed to this branch.
Let me know if you find it inappropriate for people to push to other people's branches.

@michaelpj
Copy link
Collaborator Author

Let me know if you find it inappropriate for people to push to other people's branches.

I think it's generally helpful in the case of resolving conflicts (unless you do it wrong :p ). So thanks!

@michaelpj michaelpj merged commit 975db49 into master Feb 2, 2024
@jhrcek jhrcek deleted the mpj/ghc2021 branch March 2, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants