Skip to content

Filter generated Core variable names from hovertip documentation #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 7, 2023
Merged

Filter generated Core variable names from hovertip documentation #3316

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9e86954
Filter names from hovertip documentation which match patterns of gene…
drone29a Oct 7, 2022
4001aa3
Added comment for isInternal function.
drone29a Nov 2, 2022
27e9a10
Relocated list of OccName prefixes from the Completions plugin to the…
drone29a Nov 19, 2022
8ca04ab
Added test data and test for ensuring Core-generated variables are no…
drone29a Nov 20, 2022
92d5a99
Switched to using isEvidenceContext to filter out evidence bindings.
drone29a Feb 3, 2023
0cea12e
Relocated list of OccName prefixes from the Completions plugin to the…
drone29a Nov 19, 2022
7eebe95
Removed unused import.
drone29a Feb 3, 2023
9b1cd25
Relocated list of OccName prefixes from the Completions plugin to the…
drone29a Nov 19, 2022
bbd73da
Removed unused import.
drone29a Feb 3, 2023
488f23d
Fixed incorrect definition of mkRecordSnippetCompItem introduced when…
drone29a Feb 4, 2023
30c42bb
Add preprocessor check for GHC version before using isEvidenceContext…
drone29a Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed incorrect definition of mkRecordSnippetCompItem introduced when… 
… rebasing.
  • Loading branch information
@drone29a
drone29a committed Feb 4, 2023
commit 488f23d9247611994b97d4f02a89e0111c00358f
13 changes: 2 additions & 11 deletions ghcide/src/Development/IDE/Plugin/Completions/Logic.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,17 +770,8 @@ stripPrefix :: T.Text -> T.Text
stripPrefix name = T.takeWhile (/=':') $ fromMaybe name $
getFirst $ foldMap (First . (`T.stripPrefix` name)) occNamePrefixes

safeTyThingForRecord :: TyThing -> Maybe (T.Text, [T.Text])
safeTyThingForRecord (AnId _) = Nothing
safeTyThingForRecord (AConLike dc) =
let ctxStr = printOutputable . occName . conLikeName $ dc
field_names = T.pack . unpackFS . flLabel <$> conLikeFieldLabels dc
in
Just (ctxStr, field_names)
safeTyThingForRecord _ = Nothing

mkRecordSnippetCompItem :: Uri -> Maybe T.Text -> T.Text -> [T.Text] -> Provenance -> SpanDoc -> Maybe (LImportDecl GhcPs) -> CompItem
mkRecordSnippetCompItem uri parent ctxStr compl importedFrom docs imp = r
mkRecordSnippetCompItem :: Uri -> Maybe T.Text -> T.Text -> [T.Text] -> Provenance -> Maybe (LImportDecl GhcPs) -> CompItem
mkRecordSnippetCompItem uri parent ctxStr compl importedFrom imp = r
where
r = CI {
compKind = CiSnippet
Expand Down