Skip to content

Fix min bound for ghc-exactprint dependency in hls-class-plugin #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

Fix min bound for ghc-exactprint dependency in hls-class-plugin #2710

merged 1 commit into from
Feb 14, 2022

Conversation

@pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Feb 13, 2022 •
edited by gitpod-io bot
Loading

Earlier versions of ghc-exactprint lead to a build error:

[1 of 1] Compiling Ide.Plugin.Class ( src/Ide/Plugin/Class.hs, dist/dist-sandbox-fb36eb2d/build/Ide/Plugin/Class.o )

src/Ide/Plugin/Class.hs:36:59: error:
    Module `Language.Haskell.GHC.ExactPrint.Utils' does not export `rs'
   |
36 | import           Language.Haskell.GHC.ExactPrint.Utils   (rs)
   |                                                           ^^

@pepeiborra pepeiborra requested a review from Ailrun as a code owner February 13, 2022 18:44
@michaelpj michaelpj merged commit 54de5a7 into haskell:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelpj michaelpj michaelpj approved these changes

@Ailrun Ailrun Awaiting requested review from Ailrun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pepeiborra @michaelpj