Skip to content

Bump Ormolu and Fourmolu to GHC-9.2-compatible versions #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 13, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cabal-ghc901.project
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ package *

write-ghc-environment-files: never

index-state: 2021-12-29T12:30:08Z
index-state: 2022-01-10T17:57:05Z

constraints:
-- These plugins don't work on GHC9 yet
Expand Down
6 changes: 3 additions & 3 deletions cabal-ghc921.project
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ packages:
-- ./plugins/hls-tactics-plugin
-- ./plugins/hls-brittany-plugin
-- ./plugins/hls-stylish-haskell-plugin
-- ./plugins/hls-fourmolu-plugin
./plugins/hls-fourmolu-plugin
./plugins/hls-class-plugin
./plugins/hls-eval-plugin
./plugins/hls-explicit-imports-plugin
Expand All @@ -36,11 +36,11 @@ package *

write-ghc-environment-files: never

index-state: 2021-12-29T12:30:08Z
index-state: 2022-01-10T17:57:05Z

constraints:
-- These plugins doesn't work on GHC92 yet
haskell-language-server +ignore-plugins-ghc-bounds -brittany -class -fourmolu -splice -stylishhaskell -tactic -refineImports -callhierarchy -retrie
haskell-language-server +ignore-plugins-ghc-bounds -brittany -class -splice -stylishhaskell -tactic -refineImports -callhierarchy -retrie

allow-newer:
Cabal,
Expand Down
2 changes: 1 addition & 1 deletion cabal.project
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ package *

write-ghc-environment-files: never

index-state: 2021-12-29T12:30:08Z
index-state: 2022-01-10T17:57:05Z

constraints:
hyphenation +embed
Expand Down
4 changes: 2 additions & 2 deletions haskell-language-server.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ common floskell
cpp-options: -Dfloskell

common fourmolu
if flag(fourmolu) && (impl(ghc < 9.2.1) || flag(ignore-plugins-ghc-bounds))
if flag(fourmolu) && flag(ignore-plugins-ghc-bounds)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have been

if flag(fourmolu)

corrected in #2567 51db994

build-depends: hls-fourmolu-plugin ^>=1.0.0.0
cpp-options: -Dfourmolu

Expand Down Expand Up @@ -474,7 +474,7 @@ test-suite func-test
-- formatters
if flag(floskell) && (impl(ghc < 9.0.1) || flag(ignore-plugins-ghc-bounds))
cpp-options: -Dfloskell
if flag(fourmolu) && (impl(ghc < 9.2.1) || flag(ignore-plugins-ghc-bounds))
if flag(fourmolu) && flag(ignore-plugins-ghc-bounds)
cpp-options: -Dfourmolu
if flag(ormolu)
cpp-options: -Dormolu
Expand Down
2 changes: 1 addition & 1 deletion plugins/hls-fourmolu-plugin/hls-fourmolu-plugin.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ library
build-depends:
, base >=4.12 && <5
, filepath
, fourmolu ^>=0.3 || ^>=0.4
, fourmolu ^>=0.3 || ^>=0.4 || ^>= 0.5
, ghc
, ghc-boot-th
, ghcide ^>=1.5.0
Expand Down
2 changes: 1 addition & 1 deletion plugins/hls-ormolu-plugin/hls-ormolu-plugin.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ library
, hls-plugin-api >=1.1 && <1.3
, lens
, lsp
, ormolu ^>=0.1.2 || ^>= 0.2 || ^>= 0.3
, ormolu ^>=0.1.2 || ^>= 0.2 || ^>= 0.3 || ^>= 0.4
, text

default-language: Haskell2010
Expand Down