-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make code range work on comments #3005
Comments
Can someone please point me to some documentation/explaination about how Annotated parse source is built/how it works? I am stuck at how it relates with the hieAST and how to add it to the CodeRange tree. |
Disclaimer: I'm not an expert in this field, below is what I have learned from some exact-print related issues. @wz1000 knows much more. @sloorush The main difference between them is that By the way, So what is Pepe Iborra's comments may also help you. |
I believe you don't need to remove the usage of HieAST, you just need to add new nodes to the tree. In |
Is your feature request related to a problem? Please describe.
@kokobd had pointed this out. When you expand selection(using
shift+alt+right arrow
) from within a comment, expand selection does not work on comments.Describe the solution you'd like
It is because comments are not included in HieAST, which we use for constructing ranges in the
hls-selection-range-plugin
.Annotated ParsedSource
can be used to handle structures not inHieAST
properly.More information about it --> https://gitlab.haskell.org/ghc/ghc/-/wikis/api-annotations#comments
cc: @kokobd
The text was updated successfully, but these errors were encountered: