Wrong module name suggestions when using a bios cradle

[jneira]

• Extracted from HLS seems confused about the source directory #1901, reported by @chris-martin
• Cradle output:

-ihaskell/typeclasses/src
-XApplicativeDo
-XBlockArguments
-XDeriveFunctor
[...]
Typeclasses.Postgres.Querying
Typeclasses.Postgres.Connection.PoolSetup
Typeclasses.Postgres.Connection.Secrets
[...]

• Wrong recommendation:

/cc @tittoassini (plugin author)

[chris-martin]

I've also tried modifying my cradle to output paths instead, and I still get the same result.

[jneira]

Yeah it seems it is picking the workspace root dir (where the hie.yaml lives?) instead ${workspace_root}/haskell/typeclasses/src as base dir to produce suggestions

[cdsmith]

There are two problems here, one with haskell-language-server, and one with the test case:

1. The problem with the test case is that it doesn't clear the import paths, so . is still in there. You can fix this by passing just -i followed by -ihaskell/typeclasses/src. The first argument clear the list of import paths to remove .
2. The problem with haskell-language-server is that the module name plugin misbehaves when one source path is nested inside of another. It should really check whether the module name is correct relative to any of the import paths, rather than stopping at the first one.

[cdsmith]

I'm working on a PR for this.