Skip to content

Case-insensitive changelog & readme file extension check #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Case-insensitive changelog & readme file extension check #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69756a7
Case-insensitive changelog file extension check
wismill Feb 9, 2023
ae4edfc
Case-insensitive readme file extension check
wismill Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Distribution/Server/Packages/ChangeLog.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import Data.Char as Char


isChangeLogFile :: FilePath -> Bool
isChangeLogFile fname = map Char.toLower base `elem` basenames
isChangeLogFile fname = base `elem` basenames
&& ext `elem` extensions
where
(base, ext) = splitExtension fname
(base, ext) = splitExtension (map Char.toLower fname)
basenames = ["news", "changelog", "change_log", "changes"]
extensions = ["", ".txt", ".md", ".markdown"]
6 changes: 3 additions & 3 deletions src/Distribution/Server/Packages/Readme.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import System.FilePath (splitExtension)
import Data.Char as Char

isReadmeFile :: FilePath -> Bool
isReadmeFile fname = map Char.toLower base `elem` basenames
&& ext `elem` extensions
isReadmeFile fname = base `elem` basenames
&& ext `elem` extensions
where
(base, ext) = splitExtension fname
(base, ext) = splitExtension (map Char.toLower fname)
basenames = ["readme"]
extensions = ["", ".txt", ".html", ".md", ".markdown"]