Skip to content

Minimal migration to Cabal-3.6.3.0 #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2022
Merged

Minimal migration to Cabal-3.6.3.0 #1038

merged 5 commits into from
Mar 28, 2022

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Mar 27, 2022 •
edited
Loading

This patch makes the minimal changes to compile with Cabal-3.6.3.0.
UPDATE: This also enables compilation with GHC 9.2 (#1040).

Cabal-3.6 intends a semantics of the caret operator ^>= that is more subtle than expanding it into its version interval.
We do not pick up this intention in this patch, but fall back to

Distribution.Types.VersionInterval.Legacy

Further background:

Cabal-3.6 probably also intends a safer handling of pathes (SymbolicPath), yet we simply fall back to FilePath using getSymbolicPath.

Questions to reviewer:

  • Are there new feature in Cabal-3.6 that would require a complementing implementation on the hackage-server side?

@andreasabel andreasabel added the re: Cabal-3.6 Concerning building with the Cabal-3.6 library label Mar 27, 2022
@andreasabel andreasabel requested a review from gbaz March 27, 2022 19:29
@andreasabel
Minimal migration to Cabal-3.6.3.0
c2cbecb 
This patch makes the minimal changes to compile with Cabal-3.6.3.0.

Cabal-3.6 intends a semantics of the caret operator ^>= that is more
subtle than expanding it into its version interval.
We do not pick up this intention in this patch, but fall back to

  Distribution.Types.VersionInterval.Legacy

See haskell/cabal#7916 for a in-depth
discussion.
This was referenced Mar 27, 2022
Closed
Closed
@andreasabel andreasabel linked an issue Mar 28, 2022 that may be closed by this pull request
Build with GHC-9.2 #1040
Closed
4 tasks
@andreasabel andreasabel mentioned this pull request Mar 28, 2022
Closed
3 tasks
@andreasabel
Build with GHC 9.2
7095333
@andreasabel
PackageTestMain: comments, cosmetical changes
ac439ee
@andreasabel
PackageTestMain: factor out successTest
4675d01
@andreasabel
Fix #1030: test case
fa633f5 
When building with Cabal-3.6.*, Hackage server will accept the latest
GHC LANGUAGE extensions (new in GHC 9.2).
@gbaz gbaz merged commit e7570cc into master Mar 28, 2022
@andreasabel andreasabel mentioned this pull request Mar 29, 2022
Open
@andreasabel andreasabel deleted the cabal-3.6 branch April 16, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaz gbaz Awaiting requested review from gbaz

Assignees
No one assigned
Labels
re: Cabal-3.6 Concerning building with the Cabal-3.6 library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build with GHC-9.2
2 participants
@andreasabel @gbaz