TUI: allow responding to prompts with Return (defaulting to Yes) #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
changed the title
jhrcek
force-pushed
the
jan/accept-default-response
branch
from
01861cc to
8b72803
Compare
|
terrific! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's this convention in linux CLI tools that if you're asking users for yes/no response, then you highlight the default choice with uppercase (e.g. [Y/n]) and let user stick with the default by just pressing Enter/Return.
This behavior is already present in bunch of places in ghcup installer. Could we please also support this in the prompts used by TUI?