This repository was archived by the owner on Jan 2, 2021. It is now read-only.
Parse module headers #511
Merged
Parse module headers #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extract getModSummaryFromImports and fix diagnostics - replace GetParsedModule by GetModSummary where possible There is only one usage of GetParsedModule left, and that is in GetSpanInfos for documentation. This the wrong approach, docs should be loaded from interface files and not from sources. TODO
Progress notifications are not being sent anymore
Instead, embed haddocks in interface files
mpickering
reviewed
Mar 30, 2020
pepeiborra
force-pushed
the
mod-summary
branch
3 times, most recently
from
50240fb to
f3d397b
Compare
|
An annoying problem I immediately ran into, if a module fails to parse because of the |
|
I am also getting a lot of traces which I assume should be removed. |
|
Ah, my bad, those traces were not intended for this PR. Will fix UPDATE: fixed |
Yup, that’s going to be annoying. First workaround that comes to mind is parse again without |
If Opt_Haddock is not enabled we parse twice to capture Haddock parse errors
I have gone with a different solution: parse files of interest twice, with and without |
cocreature
approved these changes
Apr 27, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Create rule to get ModSummary without parsing entire source file * Load file source from disk if not available in memory * Fix build after cherry pick * Couple of fixes - extract getModSummaryFromImports and fix diagnostics - replace GetParsedModule by GetModSummary where possible There is only one usage of GetParsedModule left, and that is in GetSpanInfos for documentation. This the wrong approach, docs should be loaded from interface files and not from sources. TODO * Fix watched file tests Progress notifications are not being sent anymore * Compat with GHC 8.6 * Avoid parsing source files for completions and documentation Instead, embed haddocks in interface files * Allow CPP in module * Force things after parsing in order to release buffers * avoid holding on to stringbuffer unnecessarily * Skip unnecessary file contents read * Drop HscEnv requirement * Add comments on forcing things * Add comments on GHC_LIB restriction * Parse files of interest twice to capture Haddock errors If Opt_Haddock is not enabled we parse twice to capture Haddock parse errors * Parallelize two-pass parsing * Update src/Development/IDE/Core/Compile.hs Co-authored-by: Marcelo Lazaroni <lazaronijunior@gmail.com> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Create rule to get ModSummary without parsing entire source file * Load file source from disk if not available in memory * Fix build after cherry pick * Couple of fixes - extract getModSummaryFromImports and fix diagnostics - replace GetParsedModule by GetModSummary where possible There is only one usage of GetParsedModule left, and that is in GetSpanInfos for documentation. This the wrong approach, docs should be loaded from interface files and not from sources. TODO * Fix watched file tests Progress notifications are not being sent anymore * Compat with GHC 8.6 * Avoid parsing source files for completions and documentation Instead, embed haddocks in interface files * Allow CPP in module * Force things after parsing in order to release buffers * avoid holding on to stringbuffer unnecessarily * Skip unnecessary file contents read * Drop HscEnv requirement * Add comments on forcing things * Add comments on GHC_LIB restriction * Parse files of interest twice to capture Haddock errors If Opt_Haddock is not enabled we parse twice to capture Haddock parse errors * Parallelize two-pass parsing * Update src/Development/IDE/Core/Compile.hs Co-authored-by: Marcelo Lazaroni <lazaronijunior@gmail.com> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Create rule to get ModSummary without parsing entire source file * Load file source from disk if not available in memory * Fix build after cherry pick * Couple of fixes - extract getModSummaryFromImports and fix diagnostics - replace GetParsedModule by GetModSummary where possible There is only one usage of GetParsedModule left, and that is in GetSpanInfos for documentation. This the wrong approach, docs should be loaded from interface files and not from sources. TODO * Fix watched file tests Progress notifications are not being sent anymore * Compat with GHC 8.6 * Avoid parsing source files for completions and documentation Instead, embed haddocks in interface files * Allow CPP in module * Force things after parsing in order to release buffers * avoid holding on to stringbuffer unnecessarily * Skip unnecessary file contents read * Drop HscEnv requirement * Add comments on forcing things * Add comments on GHC_LIB restriction * Parse files of interest twice to capture Haddock errors If Opt_Haddock is not enabled we parse twice to capture Haddock parse errors * Parallelize two-pass parsing * Update src/Development/IDE/Core/Compile.hs Co-authored-by: Marcelo Lazaroni <lazaronijunior@gmail.com> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of full modules, ghcide now parses only the module headers and avoids storing unnecessary ASTs in the Shake graph where possible. This happens in a couple of places:
ModSummaryinstead of aParsedModuleModIfaceinstead, i.e. a.hifile.ghc-lib. Otherwise,ModIfaceis used instead.Altogether, ghcide only parses full modules for files of interest now, or for dependencies when an up-to-date
.hifile is not available. The main benefits areJoint work with @lazamar.
Fixes #505