This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Remove JSON instances for unused completion code #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
pushed a commit
to pepeiborra/ghcide
that referenced
this pull request
Feb 1, 2020
* Remove JSON instances for completions, since we are not implementing "resolve" * Remove completion resolve data from tests
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Remove JSON instances for completions, since we are not implementing "resolve" * Remove completion resolve data from tests
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Remove JSON instances for completions, since we are not implementing "resolve" * Remove completion resolve data from tests
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Remove JSON instances for completions, since we are not implementing "resolve" * Remove completion resolve data from tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is one half of the one originally in #288
According to #227 (comment), such instances are only required for implementing the "resolve completion" functionality in LSP. However, at this moment all the information is returned directly in the completion request, so there's no need for that. This PR removes the code, and also updates the tests.