Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Use IdeResult in generateCore #180

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Use IdeResult in generateCore #180

merged 1 commit into from
Oct 28, 2019

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Oct 28, 2019

use the IdeResult type synonym in the new generateCore function's return
type instead of effectively inlining it.


This change is Reviewable

use the `IdeResult` type synonym in the new `generateCore` function's return
type instead of effectively inlining it.
@hurryabit hurryabit requested a review from cocreature October 28, 2019 20:34
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks!

@hurryabit hurryabit merged commit e9d862e into master Oct 28, 2019
@hurryabit hurryabit deleted the generate-core-ide-result branch October 28, 2019 21:08
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
use the `IdeResult` type synonym in the new `generateCore` function's return
type instead of effectively inlining it.
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
use the `IdeResult` type synonym in the new `generateCore` function's return
type instead of effectively inlining it.
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
use the `IdeResult` type synonym in the new `generateCore` function's return
type instead of effectively inlining it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants