Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Use a separate finder cache for each typecheck call #148

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

cocreature
Copy link
Collaborator

On a large DAML project, we occasionally saw error about missing
modules during typechecking during concurrent compilations. This was
caused by the fact that we modified the IORef in the HscEnv which is
shared between concurrent compilations.

On a large DAML project, we occasionally saw error about missing
modules during typechecking during concurrent compilations. This was
caused by the fact that we modified the IORef in the HscEnv which is
shared between concurrent compilations.
@cocreature cocreature requested review from hurryabit and a user October 2, 2019 11:31
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@cocreature cocreature merged commit ed6cf47 into master Oct 2, 2019
@cocreature cocreature deleted the debug-loc-module branch October 2, 2019 11:58
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Use a separate finder cache for each typecheck call

On a large DAML project, we occasionally saw error about missing
modules during typechecking during concurrent compilations. This was
caused by the fact that we modified the IORef in the HscEnv which is
shared between concurrent compilations.
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Use a separate finder cache for each typecheck call

On a large DAML project, we occasionally saw error about missing
modules during typechecking during concurrent compilations. This was
caused by the fact that we modified the IORef in the HscEnv which is
shared between concurrent compilations.
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Use a separate finder cache for each typecheck call

On a large DAML project, we occasionally saw error about missing
modules during typechecking during concurrent compilations. This was
caused by the fact that we modified the IORef in the HscEnv which is
shared between concurrent compilations.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants