This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Refactor goto-definition and hover tests #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacg
force-pushed
the
refactor-tests
branch
3 times, most recently
from
526f837 to
bbb77b0
Compare
+ Reduce manual duplication of information shared between hover and goto-def tests + Make sure that all the information in the test specifications that relates to fiddly line and column numbers, fits together on one screen, and is generally easier to match and understand by eye.
jacg
force-pushed
the
refactor-tests
branch
from
bbb77b0 to
aafbc3c
Compare
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
+ Reduce manual duplication of information shared between hover and goto-def tests + Make sure that all the information in the test specifications that relates to fiddly line and column numbers, fits together on one screen, and is generally easier to match and understand by eye.
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
+ Reduce manual duplication of information shared between hover and goto-def tests + Make sure that all the information in the test specifications that relates to fiddly line and column numbers, fits together on one screen, and is generally easier to match and understand by eye.
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
+ Reduce manual duplication of information shared between hover and goto-def tests + Make sure that all the information in the test specifications that relates to fiddly line and column numbers, fits together on one screen, and is generally easier to match and understand by eye.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce manual duplication of information shared between hover and
goto-def tests
Make sure that all the information in the test specifications that
relates to fiddly line and column numbers, fits together on one
screen, and is generally easier to match and understand by eye.