-
Notifications
You must be signed in to change notification settings - Fork 96
Conversation
36d5ed9
to
197cec2
Compare
See https://downloads.haskell.org/~ghc/7.8.3/docs/html/users_guide/options-phases.html 4.12.3 for the things GHC gives you to get the version. Unfortunately it doesn't have enough info. However, there is a base version which forms a 1:1 mapping with GHC version. https://wiki.haskell.org/Base_package#Versions has a partial map, but someone seems to have forgotten to define it recently. I suggest we add System.Info.Extra.compilerVersionFull :: Version which gives us what we need. We then propose that for addition to GHC at some point. We would build it using base versions. It's a pain since it needs updating on every point release. |
So should we just merge this as is, to provide |
Makes sense, yep. |
I looked into adding precise GHC version in However, Cabal predefines:
So just using CPP should be sufficient. |
197cec2
to
b933c79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
* Add --version CLI option * Extract ghcide version from cabal * Extract precise GHC version from cabal preprocessor macro
* Add --version CLI option * Extract ghcide version from cabal * Extract precise GHC version from cabal preprocessor macro
* Add --version CLI option * Extract ghcide version from cabal * Extract precise GHC version from cabal preprocessor macro
ghcide
version?Closes #103.