Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Update optparse-applicative to master and use prettyprinter library instead #241

Closed
wants to merge 1 commit into from

Conversation

newhoggy
Copy link

No description provided.

@newhoggy newhoggy changed the title Update optparse-applicative to master WIP Update optparse-applicative to master and use prettyprinter library instead Jul 21, 2021
@RyanGlScott
Copy link
Member

Thanks for the PR, @newhoggy. I'm a bit unclear on what the purpose of this PR is. Is the goal to replace the use of ansi-wl-pprint with prettyprinter? If so, then optparse-applicative (a dependency of criterion) will need to be patched first, as its footerDoc function (which criterion uses) makes use of ansi-wl-pprint's Doc type rather that prettyprinter's Doc.

The PR title mentions something about optparse-applicative master, but as far as I can tell, the master branch of optparse-applicative still uses ansi-wl-pprint, and the PR itself doesn't change the version of optparse-applicative being used. As things stand, I'm uncertain how this is meant to work.

@Bodigrim
Copy link

@RyanGlScott I think this is a counterpart of pcapriotti/optparse-applicative#428

@RyanGlScott
Copy link
Member

RyanGlScott commented May 23, 2023

optparse-applicative recently made two releases that support prettyprinter:

  • optparse-applicative-0.17.1.0 supports ansi-wl-pprint-1.*, which re-exports prettyprinter functionality.
  • optparse-applicative-0.18.0.0 drops its ansi-wl-pprint dependency and instead depends on prettyprinter directly.

I think we should follow suit in criterion. I'll prepare a series of two PRs (based on the changes in #241 and #242) such that we will have:

  • A criterion release that supports optparse-applicative-0.18.*, in addition to previous optparse-applicative releases that use ansi-wl-pprint.
  • A criterion release that requires optparse-applicative-0.18.* or later and explicitly depends on prettyprinter.

@RyanGlScott
Copy link
Member

See #275 (which widens optparse-applicative support) and #276 (which requires optparse-applicative-0.18.* as the minimum).

@RyanGlScott
Copy link
Member

I've released criterion-1.6.1.0 and criterion-1.6.2.0 to Hackage, which include the changes from #275 and #276, respectively. As such, this PR has been superseded, so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants