Change example to not be contrived due to a duplicate value #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeowl
approved these changes
Nov 14, 2025
Contributor
treeowl
left a comment
treeowl
left a comment
There was a problem hiding this comment.
Strictly an improvement. Thanks.
meooow25
approved these changes
Nov 18, 2025
Contributor
meooow25
left a comment
meooow25
left a comment
There was a problem hiding this comment.
Would you mind making the same change in Data.Map.Lazy?
lehins
force-pushed
the
improve-example-clarity
branch
from
ddca78e to
03e5a6e
Compare
Contributor
Author
Not at all. I already forgot about existence of the lazy interface 😄 |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about others, but having the same value in the list made it really hard to follow the example.
I think it will be slightly clearer if there are no duplicate values, especially considering that they serve as an indicator what happens upon duplicate keys.