Guard PackageInfo behind cabal-version: 3.10 #9374
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to ffa9f01 which introduced a new Cabal functionality without protecting it behind a new cabal-version, therefore breaking forward compatibility.
I am marking this as a draft because I have just emulated other checks without knowing how it works. That said, the example in #9331 (comment) gets be rejected.
TODOs:
cabal-version <2.2 + PackageInfo_module + default-extensions
should never trigger.Note: This adds the constructor
CabalSpecV3_10
toCabalSpecVersion
and is therefore a breaking change toCabal-syntax
.Closes: #9331