Skip to content

Guard PackageInfo behind cabal-version: 3.10 #9374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andreabedini
Copy link
Collaborator

@andreabedini andreabedini commented Oct 27, 2023

This is a fix to ffa9f01 which introduced a new Cabal functionality without protecting it behind a new cabal-version, therefore breaking forward compatibility.

I am marking this as a draft because I have just emulated other checks without knowing how it works. That said, the example in #9331 (comment) gets be rejected.

TODOs:

Note: This adds the constructor CabalSpecV3_10 to CabalSpecVersion and is therefore a breaking change to Cabal-syntax.

Closes: #9331

This is a fix to ffa9f01 which
introduced a new Cabal functionality without protecting it behind a new
cabal-version, therefore breaking forward compatibility.
@andreabedini
Copy link
Collaborator Author

Also to discuss is how to release this. As noted above it's a breaking change to Cabal-syntax. So we cannot really release it as a patch release.

@fgaz
Copy link
Member

fgaz commented Oct 27, 2023

I think the only way is to disable the new functionality unconditionally in a patch release, then enable it conditionally in the next major release (so on cabal-version >= 3.11, not 3.10)

edit: let's discuss in #9331

@gbaz
Copy link
Collaborator

gbaz commented Nov 15, 2023

doesn't it make sense to keep the other check too?

@andreabedini
Copy link
Collaborator Author

AFAIK this was resolved in other PRs.

@andreabedini andreabedini deleted the andrea/cabal-version-for-package-infos branch June 3, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PackageInfo functionality is not guarded behind cabal-version.
3 participants