Require version 3,11 of Cabal to support --semaphore flag #9221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheaf
reviewed
Aug 30, 2023
Kleidukos
approved these changes
Aug 30, 2023
|
@mpickering care to set the "merge_me` label? |
|
Ideally after adding the comment @sheaf proposes, I guess? |
|
I just went head, committed @sheaf's suggestion and updated the branch. |
alt-romes
reviewed
Nov 2, 2023
Comment on lines
4287
to
4289
| -- Cabal 3.11 is the first version that supports parallelism semaphores | ||
| then par_strat |
There was a problem hiding this comment.
Suggested change
| -- Cabal 3.11 is the first version that supports parallelism semaphores | |
| then par_strat | |
| then -- Cabal 3.11 is the first version that supports parallelism semaphores | |
| par_strat |
There was a problem hiding this comment.
CI fails because of formoulu, this should fix it.
There was a problem hiding this comment.
@mpickering care to set the "merge_me` label, after committing this change, if it looks right to you?
mergify
bot
added
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9197