Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haddock: Don't pass --quickjump uncoditionally #9072

Closed
wants to merge 1 commit into from
Closed

Haddock: Don't pass --quickjump uncoditionally #9072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Haddock: Don't pass --quickjump uncoditionally 
Fix #9060 and improve #8326, i.e. with GHC < 9.4 `cabal haddock
--enable-doc` works in more situations. #8326 is not fixed because
`cabal haddock --enable-doc --haddock-for-hackage` still fails
and doesn't seem to be fixable without upgrading to a newer
GHC (9.4+) and Haddock.
  • Loading branch information
@ulysses4ever
ulysses4ever committed Jun 29, 2023
commit 29e37d4a50b862ddf2c812932049d45ad51ecd9b
2 changes: 1 addition & 1 deletion Cabal/src/Distribution/Simple/Haddock.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ renderPureArgs version comp platform args =
$ args
else []
, ["--since-qual=external" | isVersion 2 20]
, [ "--quickjump" | isVersion 2 19, _ <- flagToList . argQuickJump $ args
, [ "--quickjump" | isVersion 2 19, True <- flagToList . argQuickJump $ args
]
, [ "--hyperlinked-source" | isVersion 2 17, True <- flagToList . argLinkedSource $ args
]
Expand Down