-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cabal Error Refactor #9018
Merged
Merged
Cabal Error Refactor #9018
Changes from 29 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
4a438ba
I have added a function "dieWithException" which will replace the die…
SuganyaAK fe970bc
Codebase is formatted with fourmolu and compiled without warnings.
SuganyaAK 722d778
Enabled fourmolu action
SuganyaAK 574bf67
Running fourmolu through github action as the previous ones failed.
SuganyaAK 5663f3b
Function `exceptionWithMetadata` and constructors for each exception …
SuganyaAK 7bdb74d
I have added a function "dieWithException" which will replace the die…
SuganyaAK 570d1e5
Codebase is formatted with fourmolu and compiled without warnings.
SuganyaAK 6842366
Enabled fourmolu action
SuganyaAK 3f11d92
Running fourmolu through github action as the previous ones failed.
SuganyaAK 9e6a92c
Function `exceptionWithMetadata` and constructors for each exception …
SuganyaAK efac6a4
Updated changelog
SuganyaAK 56a58ac
Merge branch 'Cabal-Error-Refactor' of https://github.com/SuganyaAK/c…
SuganyaAK 9c90d0b
PatternMatching cases of diewithexception and displayexception reduced
SuganyaAK 56e4473
Delete fourmolu.yaml
SuganyaAK b47370b
Delete settings.json
SuganyaAK 0e7f15a
Replaced die' calls for modules srcDist.hs and HcPkg.hs
SuganyaAK a1365df
Merge branch 'Cabal-Error-Refactor' of https://github.com/SuganyaAK/c…
SuganyaAK 7e017ba
Replaced die' calls in modules `build.hs`,`Haddock.hs` and `Program.hs`
SuganyaAK fb3275a
Replaced die' calls in modules `Build.hs`, `Haddock.hs` and `Program.hs`
SuganyaAK 6a4a886
Replaced die' calls in modules `GHCJS.hs`, `HaskellSuite.hs` and `Bui…
SuganyaAK 1e0bbef
Merge branch 'master' into Cabal-Error-Refactor
SuganyaAK fe51fb1
Formatted the codebase with Fourmolu
SuganyaAK d47b8ae
Accepted the new output with error codes and adding the file relevant…
SuganyaAK 2fe47db
Changes in `Utils.hs` and `Errors.hs` to reflect the new error codes
SuganyaAK 2ad952d
Keeping rip intact
SuganyaAK bbc63bc
test changes
gbaz cf5a38f
CallStack unmarked from the error output
SuganyaAK 972eb33
callstack unmarked from output
SuganyaAK 12a5846
unmarked callstack in test output
gbaz 2fd3503
Format the codebase with fourmolu
SuganyaAK 9aa458c
Changed to Error identifier to "Cabal-"
SuganyaAK 2dc8828
Updated Constructors as per review comments
SuganyaAK 4fd1225
Rectifying Hlint warning
SuganyaAK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC, why is it spelled "Soure" instead of "Source"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it was a typo, Thanks for pointing out. Changed to "CantFindSourceModule"