Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how to install cabal-head via GHCup #9001

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Jun 4, 2023


Please include the following checklist in your PR:

  • The documentation has been updated, if necessary.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatically, that "Or" doesn't quite make sense to me. I added a suggestion to add some text and move there your #-comment.

@mouse07410
Copy link
Collaborator

Any reason why AARCH64 binaries aren't available, e.g., for MacOS?

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jun 4, 2023

Actually, we should add a comment that Linux can be replaced with Windows or MacOS.

@ulysses4ever
Copy link
Collaborator

@mouse07410 because these are GitHub prereleases, and GitHub doesn't provide AARCH64 runners. Releases, on the other hand, are built on GitLab where we have "our own" runners, including AARCH64. If you think you could implement a prerelease workflow that would employ GirLab, I think, everyone will be very grateful.

@ulysses4ever
Copy link
Collaborator

@ffaf1 merge label?

@ffaf1 ffaf1 added the merge me Tell Mergify Bot to merge label Jun 9, 2023
@hasufell
Copy link
Member

hasufell commented Jun 9, 2023

and GitHub doesn't provide AARCH64 runners

It does. @angerman and me have set up and developed CI that works with privately hosted runners on aarch64 macOS.

We have repeatedly advertised this capability and I have repeatedly offered to migrate all Cabal CI to Github, but cabal devs have always raised concerns.

So... this is up to cabal devs. We can enable and expose these runners if need be.

@gbaz
Copy link
Collaborator

gbaz commented Jun 9, 2023

We can enable and expose these runners if need be.

I think we would all love that for the CI pipeline, and there is no objection!

The disagreements were over what would happen with the release pipeline, but we need not let that get in the way of making our CI system better :-)

@ulysses4ever
Copy link
Collaborator

By all means. Just want to make sure that everyone is on the same page here: the prerelease workflow is currently completely independent of release process, and I'm not aware of any plans to converge them.

README.md Outdated
ghcup install cabal -u https://github.com/haskell/cabal/releases/download/cabal-head/cabal-head-Linux-x86_64.tar.gz head
```

Replace "Linux" with "Windows" or "MacOS" as appropriate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Replace "Linux" with "Windows" or "MacOS" as appropriate.
Replace "Linux" with "Windows" or "macOS" as appropriate.

This is weird but that's how it's spelled by GitHub somehow...

@ffaf1 ffaf1 force-pushed the head-ghcup branch 2 times, most recently from 79d8e4c to 07da828 Compare June 10, 2023 14:54
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 12, 2023
@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit e71f6f2 into haskell:master Jun 15, 2023
@ffaf1 ffaf1 deleted the head-ghcup branch July 1, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants